From 1dd17de8e9da8d73baee1809846aab94bc56f564 Mon Sep 17 00:00:00 2001
From: Robin Cornett <hello@robincornett.com>
Date: Mon, 18 Apr 2016 11:53:43 -0400
Subject: [PATCH] Fix label for number input accessibility

---
 includes/class-displayfeaturedimagegenesis-helper.php   | 7 +++----
 includes/class-displayfeaturedimagegenesis-settings.php | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/includes/class-displayfeaturedimagegenesis-helper.php b/includes/class-displayfeaturedimagegenesis-helper.php
index 68c626b..975f395 100644
--- a/includes/class-displayfeaturedimagegenesis-helper.php
+++ b/includes/class-displayfeaturedimagegenesis-helper.php
@@ -69,14 +69,13 @@ class Display_Featured_Image_Genesis_Helper {
 	 * @since 2.3.0
 	 */
 	public function do_number( $args ) {
-
-		printf( '<label for="%s[%s]">%s</label>', esc_attr( $this->page ),esc_attr( $args['setting'] ), esc_attr( $args['label'] ) );
-		printf( '<input type="number" step="1" min="%1$s" max="%2$s" id="%5$s[%3$s]" name="%5$s[%3$s]" value="%4$s" class="small-text" />',
+		printf( '<label for="%5$s[%3$s]"><input type="number" step="1" min="%1$s" max="%2$s" id="%5$s[%3$s]" name="%5$s[%3$s]" value="%4$s" class="small-text" />%6$s</label>',
 			(int) $args['min'],
 			(int) $args['max'],
 			esc_attr( $args['setting'] ),
 			esc_attr( $this->setting[ $args['setting'] ] ),
-			esc_attr( $this->page )
+			esc_attr( $this->page ),
+			esc_attr( $args['label'] )
 		);
 		$this->do_description( $args['setting'] );
 
diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php
index d424a3a..7057cf9 100644
--- a/includes/class-displayfeaturedimagegenesis-settings.php
+++ b/includes/class-displayfeaturedimagegenesis-settings.php
@@ -176,7 +176,7 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 				'title'    => __( 'Height' , 'display-featured-image-genesis' ),
 				'callback' => 'do_number',
 				'section'  => 'main',
-				'args'     => array( 'setting' => 'less_header', 'label' => __( 'Pixels to remove ', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 400 ),
+				'args'     => array( 'setting' => 'less_header', 'label' => __( 'pixels to remove', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 400 ),
 			),
 			array(
 				'id'       => 'default',