From 27a9fa40d7938bced9af4390e9af2ebaf7bf4a1f Mon Sep 17 00:00:00 2001
From: Robin Cornett <hello@robincornett.com>
Date: Tue, 21 Nov 2017 11:21:13 -0500
Subject: [PATCH] Change post meta values

---
 .../class-displayfeaturedimagegenesis-common.php |  8 +++-----
 ...lass-displayfeaturedimagegenesis-postmeta.php | 16 ++++++++++------
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/includes/class-displayfeaturedimagegenesis-common.php b/includes/class-displayfeaturedimagegenesis-common.php
index 35b7da8..eb686c1 100644
--- a/includes/class-displayfeaturedimagegenesis-common.php
+++ b/includes/class-displayfeaturedimagegenesis-common.php
@@ -367,11 +367,9 @@ class Display_Featured_Image_Genesis_Common {
 	public static function image_size() {
 		$setting    = displayfeaturedimagegenesis_get_setting();
 		$image_size = $setting['image_size'];
-		$post_meta  = (int) get_post_meta( get_the_ID(), '_displayfeaturedimagegenesis_disable', true );
-		if ( 2 === $post_meta ) {
-			return 'displayfeaturedimage_backstretch';
-		} elseif ( 3 === $post_meta ) {
-			return 'large';
+		$post_meta  = get_post_meta( get_the_ID(), '_displayfeaturedimagegenesis_disable', true );
+		if ( ! is_numeric( $post_meta ) ) {
+			return $post_meta;
 		}
 		/**
 		 * Creates display_featured_image_genesis_use_large_image filter to check
diff --git a/includes/class-displayfeaturedimagegenesis-postmeta.php b/includes/class-displayfeaturedimagegenesis-postmeta.php
index 3f82fa9..9f39846 100644
--- a/includes/class-displayfeaturedimagegenesis-postmeta.php
+++ b/includes/class-displayfeaturedimagegenesis-postmeta.php
@@ -57,13 +57,14 @@ class Display_Featured_Image_Genesis_Post_Meta {
 	 */
 	protected function get_checkboxes() {
 		$checkboxes = array();
-		$setting = displayfeaturedimagegenesis_get_setting();
+		$setting    = displayfeaturedimagegenesis_get_setting();
 		if ( ! $setting['keep_titles'] ) {
 			$checkboxes[] = array(
 				'setting' => $this->move,
 				'label'   => __( 'Don\'t move the title to overlay the backstretch featured image on this post', 'display-featured-image-genesis' ),
 			);
 		}
+
 		return $checkboxes;
 	}
 
@@ -76,10 +77,10 @@ class Display_Featured_Image_Genesis_Post_Meta {
 				'setting' => $this->disable,
 				'label'   => __( 'Featured Image Size:', 'display-featured-image-genesis' ),
 				'options' => array(
-					0 => __( 'Content type default', 'display-featured-image-genesis' ),
-					1 => __( 'Don\'t display the featured image', 'display-featured-image-genesis' ),
-					2 => __( 'Use a backstretch image if it exists', 'display-featured-image-genesis' ),
-					3 => __( 'Use a large (not backstretch) image', 'display-featured-image-genesis' ),
+					0                                  => __( 'Content type default', 'display-featured-image-genesis' ),
+					1                                  => __( 'Don\'t display the featured image', 'display-featured-image-genesis' ),
+					'displayfeaturedimage_backstretch' => __( 'Use a backstretch image if it exists', 'display-featured-image-genesis' ),
+					'large'                            => __( 'Use a large (not backstretch) image', 'display-featured-image-genesis' ),
 				),
 			),
 		);
@@ -132,6 +133,7 @@ class Display_Featured_Image_Genesis_Post_Meta {
 
 	/**
 	 * Update the post meta.
+	 *
 	 * @param $post_id
 	 */
 	public function save_meta( $post_id ) {
@@ -163,7 +165,9 @@ class Display_Featured_Image_Genesis_Post_Meta {
 
 		$select = $this->get_select();
 		foreach ( $select as $s ) {
-			update_post_meta( $post_id, $s['setting'], (int) ( $_POST[ $s['setting'] ] ) );
+			$value = sanitize_text_field( $_POST[ $s['setting'] ] );
+			$value = is_numeric( $value ) ? (int) $value : esc_attr( $value );
+			update_post_meta( $post_id, $s['setting'], $value );
 		}
 	}