From 822174817dd32032647210fde02cb2fe50e3c567 Mon Sep 17 00:00:00 2001
From: Robin Cornett <hello@robincornett.com>
Date: Wed, 6 Jul 2016 09:42:48 -0400
Subject: [PATCH] Add backstretch variables to settings page

Image centering/fade values for javascript. Includes radio buttons and
making a new style tab.
---
 ...displayfeaturedimagegenesis-getsetting.php |  27 ++--
 ...ass-displayfeaturedimagegenesis-helper.php |  20 +++
 ...ass-displayfeaturedimagegenesis-output.php |   6 +-
 ...s-displayfeaturedimagegenesis-settings.php | 120 +++++++++++++++---
 4 files changed, 138 insertions(+), 35 deletions(-)

diff --git a/includes/class-displayfeaturedimagegenesis-getsetting.php b/includes/class-displayfeaturedimagegenesis-getsetting.php
index b511933..86f5026 100644
--- a/includes/class-displayfeaturedimagegenesis-getsetting.php
+++ b/includes/class-displayfeaturedimagegenesis-getsetting.php
@@ -14,19 +14,22 @@ class DisplayFeaturedImageGenesisGetSetting {
 	 */
 	public function defaults() {
 		return apply_filters( 'displayfeaturedimagegenesis_defaults', array(
-			'less_header'   => 0,
-			'default'       => '',
-			'exclude_front' => 0,
-			'keep_titles'   => 0,
-			'move_excerpts' => 0,
-			'is_paged'      => 0,
-			'feed_image'    => 0,
-			'thumbnails'    => 0,
-			'post_types'    => array(),
-			'skip'          => array(),
-			'fallback'      => array(),
-			'max_height'    => '',
+			'less_header'    => 0,
+			'default'        => '',
+			'exclude_front'  => 0,
+			'keep_titles'    => 0,
+			'move_excerpts'  => 0,
+			'is_paged'       => 0,
+			'feed_image'     => 0,
+			'thumbnails'     => 0,
+			'post_types'     => array(),
+			'skip'           => array(),
+			'fallback'       => array(),
+			'max_height'     => '',
 			'always_default' => 0,
+			'centeredX'      => 1,
+			'centeredY'      => 1,
+			'fade'           => 750,
 		) );
 	}
 
diff --git a/includes/class-displayfeaturedimagegenesis-helper.php b/includes/class-displayfeaturedimagegenesis-helper.php
index 1dc4ba9..6d26047 100644
--- a/includes/class-displayfeaturedimagegenesis-helper.php
+++ b/includes/class-displayfeaturedimagegenesis-helper.php
@@ -147,6 +147,26 @@ class Display_Featured_Image_Genesis_Helper extends DisplayFeaturedImageGenesisG
 		}
 	}
 
+	/**
+	 * radio buttons
+	 * @return string radio button output
+	 * @since 2.6.0
+	 */
+	public function do_radio_buttons( $args ) {
+		echo '<fieldset>';
+		printf( '<legend class="screen-reader-text">%s</legend>', $args['legend'] );
+		foreach ( $args['buttons'] as $key => $button ) {
+			printf( '<label for="%5$s[%1$s][%2$s]" style="margin-right:12px !important;"><input type="radio" id="%5$s[%1$s][%2$s]" name="%5$s[%1$s]" value="%2$s"%3$s />%4$s</label>  ',
+				esc_attr( $args['setting'] ),
+				esc_attr( $key ),
+				checked( $key, $this->setting[ $args['setting'] ], false ),
+				esc_attr( $button ),
+				esc_attr( $this->page )
+			);
+		}
+		echo '</fieldset>';
+	}
+
 	/**
 	 * Generic callback to display a field description.
 	 * @param  string $args setting name used to identify description callback
diff --git a/includes/class-displayfeaturedimagegenesis-output.php b/includes/class-displayfeaturedimagegenesis-output.php
index 8fc5874..b72bc3e 100644
--- a/includes/class-displayfeaturedimagegenesis-output.php
+++ b/includes/class-displayfeaturedimagegenesis-output.php
@@ -135,9 +135,9 @@ class Display_Featured_Image_Genesis_Output {
 	public function localize_scripts() {
 		// backstretch settings which can be filtered
 		$backstretch_vars = apply_filters( 'display_featured_image_genesis_backstretch_variables', array(
-			'centeredX' => true,
-			'centeredY' => true,
-			'fade'      => 750,
+			'centeredX' => $this->setting['centeredX'],
+			'centeredY' => $this->setting['centeredY'],
+			'fade'      => $this->setting['fade'],
 		) );
 
 		$image_id     = Display_Featured_Image_Genesis_Common::set_image_id();
diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php
index 59db83b..6775eb8 100644
--- a/includes/class-displayfeaturedimagegenesis-settings.php
+++ b/includes/class-displayfeaturedimagegenesis-settings.php
@@ -100,10 +100,7 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 	 * @since 2.5.0
 	 */
 	protected function do_tabs( $active_tab ) {
-		$tabs = array(
-			'main' => array( 'id' => 'main', 'tab' => __( 'Main', 'display-featured-image-genesis' ) ),
-			'cpt'  => array( 'id' => 'cpt', 'tab' => __( 'Content Types', 'display-featured-image-genesis' ) ),
-		);
+		$tabs    = $this->define_tabs();
 		$output  = '<div class="nav-tab-wrapper">';
 		$output .= sprintf( '<h2 id="settings-tabs" class="screen-reader-text">%s</h2>', __( 'Settings Tabs', 'display-featured-image-genesis' ) );
 		$output .= '<ul>';
@@ -127,6 +124,19 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 		register_setting( 'displayfeaturedimagegenesis', 'displayfeaturedimagegenesis', array( $this, 'do_validation_things' ) );
 	}
 
+	/**
+	 * Define tabs for the settings page.
+	 * @return array
+	 * @since 2.6.0
+	 */
+	protected function define_tabs() {
+		return array(
+			'main'  => array( 'id' => 'main', 'tab' => __( 'Main', 'display-featured-image-genesis' ) ),
+			'style' => array( 'id' => 'style', 'tab' => __( 'Backstretch Output', 'display-featured-image-genesis' ) ),
+			'cpt'   => array( 'id' => 'cpt', 'tab' => __( 'Content Types', 'display-featured-image-genesis' ) ),
+		);
+	}
+
 	/**
 	 * Register plugin settings page sections
 	 *
@@ -138,6 +148,10 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 				'id'    => 'main',
 				'title' => __( 'Optional Sitewide Settings', 'display-featured-image-genesis' ),
 			),
+			'style' => array(
+				'id'    => 'style',
+				'title' => __( 'Display Settings', 'display-featured-image-genesis' ),
+			),
 			'cpt' => array(
 				'id'    => 'cpt',
 				'title' => __( 'Featured Images for Custom Content Types', 'display-featured-image-genesis' ),
@@ -153,25 +167,15 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 	 */
 	protected function register_fields() {
 
-		return array_merge( $this->define_main_fields(), $this->define_cpt_fields() );
+		return array_merge( $this->define_main_fields(), $this->define_style_fields(), $this->define_cpt_fields() );
 	}
 
+	/**
+	 * Define the fields for the main/first tab.
+	 * @return array
+	 */
 	protected function define_main_fields() {
 		return array(
-			array(
-				'id'       => 'less_header',
-				'title'    => __( 'Height' , 'display-featured-image-genesis' ),
-				'callback' => 'do_number',
-				'section'  => 'main',
-				'args'     => array( 'setting' => 'less_header', 'label' => __( 'pixels to remove', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 400 ),
-			),
-			array(
-				'id'       => 'max_height',
-				'title'    => __( 'Maximum Height' , 'display-featured-image-genesis' ),
-				'callback' => 'do_number',
-				'section'  => 'main',
-				'args'     => array( 'setting' => 'max_height', 'label' => __( 'pixels', 'display-featured-image-genesis' ), 'min' => 100, 'max' => 1000 ),
-			),
 			array(
 				'id'       => 'default',
 				'title'    => __( 'Default Featured Image', 'display-featured-image-genesis' ),
@@ -230,6 +234,62 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 		);
 	}
 
+	/**
+	 * Define the fields for the style tab.
+	 * @return array
+	 */
+	protected function define_style_fields() {
+		return array(
+			array(
+				'id'       => 'less_header',
+				'title'    => __( 'Height' , 'display-featured-image-genesis' ),
+				'callback' => 'do_number',
+				'section'  => 'style',
+				'args'     => array( 'setting' => 'less_header', 'label' => __( 'pixels to remove', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 400 ),
+			),
+			array(
+				'id'       => 'max_height',
+				'title'    => __( 'Maximum Height' , 'display-featured-image-genesis' ),
+				'callback' => 'do_number',
+				'section'  => 'style',
+				'args'     => array( 'setting' => 'max_height', 'label' => __( 'pixels', 'display-featured-image-genesis' ), 'min' => 100, 'max' => 1000 ),
+			),
+			array(
+				'id'       => 'centeredX',
+				'title'    => __( 'Center Horizontally' , 'display-featured-image-genesis' ),
+				'callback' => 'do_radio_buttons',
+				'section'  => 'style',
+				'args'     => array(
+					'setting' => 'centeredX',
+					'buttons' => $this->pick_center(),
+					'legend'  => __( 'Center the backstretch image on the horizontal axis?', 'display-featured-image-genesis' ),
+				),
+			),
+			array(
+				'id'       => 'centeredY',
+				'title'    => __( 'Center Vertically' , 'display-featured-image-genesis' ),
+				'callback' => 'do_radio_buttons',
+				'section'  => 'style',
+				'args'     => array(
+					'setting' => 'centeredY',
+					'buttons' => $this->pick_center(),
+					'legend'  => __( 'Center the backstretch image on the vertical axis?', 'display-featured-image-genesis' ),
+				),
+			),
+			array(
+				'id'       => 'fade',
+				'title'    => __( 'Fade' , 'display-featured-image-genesis' ),
+				'callback' => 'do_number',
+				'section'  => 'style',
+				'args'     => array( 'setting' => 'fade', 'label' => __( 'milliseconds', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 20000 ),
+			),
+		);
+	}
+
+	/**
+	 * Define the fields for the content types tab.
+	 * @return array
+	 */
 	protected function define_cpt_fields() {
 		$fields = array(
 			array(
@@ -278,7 +338,15 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 	 * @since 1.1.0
 	 */
 	public function main_section_description() {
-		$description = __( 'The Display Featured Image for Genesis plugin has just a few optional settings. Check the Help tab for more information. ', 'display-featured-image-genesis' );
+		$description = __( 'Use these settings to modify the plugin behavior throughout your site. Check the Help tab for more information. ', 'display-featured-image-genesis' );
+		$this->print_section_description( $description );
+	}
+
+	/**
+	 * Style section description
+	 */
+	public function style_section_description() {
+		$description = __( 'These settings modify the output style/methods for the backstretch image.', 'display-featured-image-genesis' );
 		$this->print_section_description( $description );
 	}
 
@@ -391,6 +459,16 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 		printf( '<p class="description">%s</p>', wp_kses_post( $description ) );
 	}
 
+	/**
+	 * @return array
+	 */
+	public function pick_center() {
+		return array(
+			1 => __( 'Center', 'display-featured-image-genesis' ),
+			0 => __( 'Do Not Center', 'display-featured-image-genesis' ),
+		);
+	}
+
 	/**
 	 * validate all inputs
 	 * @param  string $new_value various settings
@@ -416,6 +494,8 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
 				$new_value[ $field['id'] ] = $this->one_zero( $new_value[ $field['id'] ] );
 			} elseif ( 'do_number' === $field['callback'] ) {
 				$new_value[ $field['id'] ] = $this->check_value( $new_value[ $field['id'] ], $this->setting[ $field['id'] ], $field['args']['min'], $field['args']['max'] );
+			} elseif ( 'do_radio_buttons' === $field['callback'] ) {
+				$new_value[ $field['id'] ] = (int) $new_value[ $field['id'] ];
 			}
 		}