From 8a18a5df5104e116f4fa4d3549186b775d12ec44 Mon Sep 17 00:00:00 2001 From: Robin Cornett Date: Wed, 30 Dec 2015 16:04:17 -0500 Subject: [PATCH] Simplify early return on ID check --- includes/class-displayfeaturedimagegenesis-common.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/includes/class-displayfeaturedimagegenesis-common.php b/includes/class-displayfeaturedimagegenesis-common.php index f765de8..6e403fb 100644 --- a/includes/class-displayfeaturedimagegenesis-common.php +++ b/includes/class-displayfeaturedimagegenesis-common.php @@ -237,16 +237,11 @@ class Display_Featured_Image_Genesis_Common { $attachment_id = false; - // as of 2.2.0, if a (new) image id is passed to the function, return it as is. - if ( is_numeric( $attachment_url ) ) { + // as of 2.2.0, if a (new) image id is passed to the function, or if it's empty, return it as is. + if ( is_numeric( $attachment_url ) || '' === $attachment_url ) { return $attachment_url; } - // If there is no url, return. - if ( '' === $attachment_url ) { - return; - } - // Get the upload directory paths $upload_dir_paths = wp_upload_dir(); $base_url = wp_make_link_relative( $upload_dir_paths['baseurl'] );