From 916b5e2b02b5e715567cd569dde3122479370968 Mon Sep 17 00:00:00 2001 From: Robin Cornett Date: Thu, 31 Mar 2016 12:39:35 -0400 Subject: [PATCH] Fix settings page Adds post, page to skip, adds margin to checkbox label --- includes/class-displayfeaturedimagegenesis-helper.php | 4 +--- includes/class-displayfeaturedimagegenesis-settings.php | 5 +++++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/includes/class-displayfeaturedimagegenesis-helper.php b/includes/class-displayfeaturedimagegenesis-helper.php index 5f7cb3b..8d86003 100644 --- a/includes/class-displayfeaturedimagegenesis-helper.php +++ b/includes/class-displayfeaturedimagegenesis-helper.php @@ -89,16 +89,14 @@ class Display_Featured_Image_Genesis_Helper { * @since 2.3.0 */ public function do_checkbox( $args ) { - echo '

'; $setting = $this->get_checkbox_setting( $args ); printf( '', esc_attr( $this->page ), esc_attr( $args['setting'] ) ); - printf( '', + printf( '', esc_attr( $args['setting'] ), checked( 1, esc_attr( $setting ), false ), esc_attr( $args['label'] ), esc_attr( $this->page ) ); - echo '

'; $this->do_description( $args['setting'] ); } diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php index 9c7d5be..fb94568 100644 --- a/includes/class-displayfeaturedimagegenesis-settings.php +++ b/includes/class-displayfeaturedimagegenesis-settings.php @@ -413,6 +413,11 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen $new_value['post_type'][ $post_type ] = $this->validate_image( $new_value['post_type'][ $post_type ], $old_value, $label, $size_to_check ); $new_value['fallback'][ $post_type ] = $this->one_zero( $new_value['fallback'][ $post_type ] ); } + $built_ins = array( 'post', 'page' ); + $post_types = array_merge( $built_ins, $this->post_types ); + foreach ( $post_types as $post_type ) { + $new_value['skip'][ $post_type ] = $this->one_zero( $new_value['skip'][ $post_type ] ); + } return $new_value;