From 9a30b702bbd959cfdb183c885bab74c4d9783453 Mon Sep 17 00:00:00 2001 From: Robin Cornett Date: Sat, 30 Apr 2016 14:20:04 -0400 Subject: [PATCH] Clean up settings variables definitions --- .../class-displayfeaturedimagegenesis-settings.php | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php index e624bf9..495b51a 100644 --- a/includes/class-displayfeaturedimagegenesis-settings.php +++ b/includes/class-displayfeaturedimagegenesis-settings.php @@ -14,7 +14,7 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen * @var option */ protected $common; - protected $page; + protected $page = 'displayfeaturedimagegenesis'; protected $setting; protected $post_types; protected $fields; @@ -26,8 +26,9 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen */ public function do_submenu_page() { - $this->page = 'displayfeaturedimagegenesis'; - $this->common = new Display_Featured_Image_Genesis_Common(); + $this->common = new Display_Featured_Image_Genesis_Common(); + $this->setting = $this->get_display_setting(); + $this->post_types = $this->get_content_types(); add_theme_page( __( 'Display Featured Image for Genesis', 'display-featured-image-genesis' ), @@ -40,10 +41,8 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen add_action( 'admin_init', array( $this, 'register_settings' ) ); add_action( 'load-appearance_page_displayfeaturedimagegenesis', array( $this, 'help' ) ); - $this->setting = $this->get_display_setting(); - $this->post_types = $this->get_content_types(); - $sections = $this->register_sections(); - $this->fields = $this->register_fields(); + $sections = $this->register_sections(); + $this->fields = $this->register_fields(); $this->add_sections( $sections ); $this->add_fields( $this->fields, $sections ); }