From b1efda929a40677b35362b0c8fed7955e4916ea2 Mon Sep 17 00:00:00 2001 From: Robin Cornett Date: Tue, 16 Aug 2016 16:33:12 -0400 Subject: [PATCH] Only allow max_height to return empty value --- includes/class-displayfeaturedimagegenesis-settings.php | 6 +++--- includes/js/backstretch-set.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/class-displayfeaturedimagegenesis-settings.php b/includes/class-displayfeaturedimagegenesis-settings.php index 772d0d2..3010d94 100644 --- a/includes/class-displayfeaturedimagegenesis-settings.php +++ b/includes/class-displayfeaturedimagegenesis-settings.php @@ -493,6 +493,9 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen if ( 'do_checkbox' === $field['callback'] ) { $new_value[ $field['id'] ] = $this->one_zero( $new_value[ $field['id'] ] ); } elseif ( 'do_number' === $field['callback'] ) { + if ( 'max_height' === $field['id'] && empty( $new_value[ $field['id'] ] ) ) { + continue; + } $new_value[ $field['id'] ] = $this->check_value( $new_value[ $field['id'] ], $this->setting[ $field['id'] ], $field['args']['min'], $field['args']['max'] ); } elseif ( 'do_radio_buttons' === $field['callback'] ) { $new_value[ $field['id'] ] = absint( $new_value[ $field['id'] ] ); @@ -555,9 +558,6 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen * @return int */ protected function check_value( $new_value, $old_value, $min, $max ) { - if ( empty( $new_value ) ) { - return ''; - } if ( $new_value >= $min && $new_value <= $max ) { return (int) $new_value; } diff --git a/includes/js/backstretch-set.js b/includes/js/backstretch-set.js index 269f24c..6db2253 100644 --- a/includes/js/backstretch-set.js +++ b/includes/js/backstretch-set.js @@ -1,4 +1,4 @@ -;( function ( document, $, undefined ) { +( function ( document, $, undefined ) { 'use strict'; var plugin = {};