From f9dfc8e1b8df95fb68b98ff0c0b66af342f859bd Mon Sep 17 00:00:00 2001 From: Robin Cornett Date: Fri, 13 Feb 2015 17:03:32 -0500 Subject: [PATCH] clarify comments, esc_url --- ...ass-displayfeaturedimagegenesis-output.php | 2 ++ ...ayfeaturedimagegenesis-taxonomy-widget.php | 24 +++++++++---------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/includes/class-displayfeaturedimagegenesis-output.php b/includes/class-displayfeaturedimagegenesis-output.php index 7843032..ebc0b1a 100644 --- a/includes/class-displayfeaturedimagegenesis-output.php +++ b/includes/class-displayfeaturedimagegenesis-output.php @@ -138,6 +138,7 @@ class Display_Featured_Image_Genesis_Output { wp_localize_script( 'displayfeaturedimage-backstretch-set', 'BackStretchVars', $output ); + // if titles will be moved to overlay backstretch image if ( ! $keep_titles ) { if ( is_singular() && ! is_front_page() && ! is_page_template( 'page_blog.php' ) ) { remove_action( 'genesis_entry_header', 'genesis_do_post_title' ); // HTML5 @@ -172,6 +173,7 @@ class Display_Featured_Image_Genesis_Output { } + // if titles are not being moved to overlay the image elseif ( ! $keep_titles ) { if ( ! empty( $item->title ) && ! is_front_page() ) { diff --git a/includes/widgets/displayfeaturedimagegenesis-taxonomy-widget.php b/includes/widgets/displayfeaturedimagegenesis-taxonomy-widget.php index cb63f2c..bd45b94 100644 --- a/includes/widgets/displayfeaturedimagegenesis-taxonomy-widget.php +++ b/includes/widgets/displayfeaturedimagegenesis-taxonomy-widget.php @@ -33,14 +33,14 @@ class Display_Featured_Image_Genesis_Widget_Taxonomy extends WP_Widget { function __construct() { $this->defaults = array( - 'title' => '', - 'taxonomy' => 'category', - 'term' => 'none', - 'show_image' => 0, - 'image_alignment' => '', - 'image_size' => 'medium', - 'show_title' => 0, - 'show_content' => 0 + 'title' => '', + 'taxonomy' => 'category', + 'term' => 'none', + 'show_image' => 0, + 'image_alignment' => '', + 'image_size' => 'medium', + 'show_title' => 0, + 'show_content' => 0 ); $widget_ops = array( @@ -99,11 +99,11 @@ class Display_Featured_Image_Genesis_Widget_Taxonomy extends WP_Widget { $image_id = Display_Featured_Image_Genesis_Common::get_image_id( $term_meta['term_image'] ); $image_src = wp_get_attachment_image_src( $image_id, $instance['image_size'] ); if ( $image_src ) { - $image = ''; + $image = ''; } if ( $instance['show_image'] && $image ) { - printf( '%s', $permalink, esc_html( $title ), esc_attr( $instance['image_alignment'] ), $image ); + printf( '%s', esc_url( $permalink ), esc_html( $title ), esc_attr( $instance['image_alignment'] ), $image ); } } @@ -112,9 +112,9 @@ class Display_Featured_Image_Genesis_Widget_Taxonomy extends WP_Widget { if ( ! empty( $instance['show_title'] ) ) { if ( genesis_html5() ) - printf( '

%s

', $permalink, esc_html( $title ) ); + printf( '

%s

', esc_url( $permalink ), esc_html( $title ) ); else - printf( '

%s

', $permalink, esc_html( $title ) ); + printf( '

%s

', esc_url( $permalink ), esc_html( $title ) ); }