Completed 1.10 (unicafe step 5)

part1/1.6-1.11-unicafe/src/App.js

@@ -11,7 +11,7 @@ const App = () => {
       const [good, neutral, bad] = props.data
       const all = good + bad + neutral
       const avg = (all !== 0) ? (good - bad) / all : 0 
-      const positive =  (all !== 0) ? good/all*100 : "NA"
+      const positive =  (all !== 0) ? good/all*100 + " %": "NA"
       
 
       return (
@@ -19,12 +19,13 @@ const App = () => {
           <h1>Statistic</h1>
           {all > 0 &&
             <div>
-              <p>Good: {good}</p>
+              <StatisticLine text="Good" value ={good} />
-              <p>Neutral: {neutral}</p>
+              <StatisticLine text="Neutral" value ={neutral} />
-              <p>Bad: {bad}</p>
+              <StatisticLine text="Bad" value ={bad} />
-              <p>All: {all}</p>
+              <StatisticLine text="All" value ={all} />
-              <p>Average: {avg} </p>
+              <StatisticLine text="Average" value ={avg} />
-              <p>Positive: {positive} %</p>
+              <StatisticLine text="Positive" value ={positive} />
+
             </div>
           }
           {all === 0 && "No feedback given"}
@@ -32,13 +33,20 @@ const App = () => {
       )
   }
 
+  const StatisticLine = (props) => <p>{props.text}: {props.value}</p>
+
+  const Button = (props) => {
+    return (
+      <button onClick={props.onClick}>{props.text}</button>
+    )
+  }
+
   return (
     <div>
       <h1>Give feedback</h1>
-
+      <Button text="good" onClick={() => setGood(good + 1)} />
-      <button onClick={() => setGood(good + 1)}>good</button>
+      <Button text="neutral" onClick={() => setNeutral(neutral + 1)} />
-      <button onClick={() => setNeutral(neutral + 1)}>neutral</button>
+      <Button text="bad" onClick={() => setBad(bad + 1)} />
-      <button onClick={() => setBad(bad + 1)}>bad</button>
 
       <Statistics data={[good, neutral, bad]}/>