From 8208d01bf81691e52775f9dfe586a56626addca9 Mon Sep 17 00:00:00 2001
From: Mykyta Synelnikov <nsinelnikov.work@gmail.com>
Date: Mon, 20 May 2024 14:23:45 +0300
Subject: [PATCH] - fixed PHP errors when some custom registered fields are
 displayed without registration;

---
 includes/core/class-fields.php      | 24 +++++++++++-------------
 includes/core/um-filters-fields.php |  2 +-
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/includes/core/class-fields.php b/includes/core/class-fields.php
index 487add7e..6e1bc572 100644
--- a/includes/core/class-fields.php
+++ b/includes/core/class-fields.php
@@ -1513,24 +1513,24 @@ if ( ! class_exists( 'um\core\Fields' ) ) {
 			return '';
 		}
 
-
 		/**
 		 * Get field label
 		 *
-		 * @param  string $key
+		 * @param string $key Field meta key
 		 *
 		 * @return string
 		 */
-		function get_label( $key ) {
-			$label = '';
+		public function get_label( $key ) {
+			$label      = '';
+			$fields     = UM()->builtin()->all_user_fields;
+			$field_data = array_key_exists( $key, $fields ) ? $fields[ $key ] : array();
 
-			$fields = UM()->builtin()->all_user_fields;
-			if ( isset( $fields[ $key ]['label'] ) ) {
-				$label = stripslashes( $fields[ $key ]['label'] );
+			if ( array_key_exists( 'label', $field_data ) ) {
+				$label = stripslashes( $field_data['label'] );
 			}
 
-			if ( empty( $label ) && isset( $fields[ $key ]['title'] ) ) {
-				$label = stripslashes( $fields[ $key ]['title'] );
+			if ( empty( $label ) && array_key_exists( 'title', $field_data ) ) {
+				$label = stripslashes( $field_data['title'] );
 			}
 
 			/**
@@ -1556,13 +1556,11 @@ if ( ! class_exists( 'um\core\Fields' ) ) {
 			 * }
 			 * add_filter( 'um_change_field_label', 'my_change_field_label', 10, 3 );
 			 */
-			$label = apply_filters( 'um_change_field_label', $label, $key, $fields[ $key ] );
+			$label = apply_filters( 'um_change_field_label', $label, $key, $field_data );
 
-			$label = sprintf( __( '%s', 'ultimate-member' ), $label );
-			return $label;
+			return sprintf( __( '%s', 'ultimate-member' ), $label );
 		}
 
-
 		/**
 		 * Get field title
 		 *
diff --git a/includes/core/um-filters-fields.php b/includes/core/um-filters-fields.php
index 8576e68a..745831f2 100644
--- a/includes/core/um-filters-fields.php
+++ b/includes/core/um-filters-fields.php
@@ -456,7 +456,7 @@ function um_profile_field_filter_hook__( $value, $data, $type = '' ) {
 		$value = '<a href="' . esc_url( $value, $protocols ) . '" title="' . esc_attr( $alt ) . '" target="' . esc_attr( $data['url_target'] ) . '" ' . $url_rel . '>' . esc_html( $alt ) . '</a>';
 	} else {
 		// check $value is oEmbed
-		if ( 'oembed' === $data['type'] ) {
+		if ( array_key_exists( 'type', $data ) && 'oembed' === $data['type'] ) {
 			return $value;
 		}