10h30/ultimatemember
1
0
Fork 0
mirror of https://github.com/10h30/ultimatemember.git synced 2026-07-14 04:06:36 +09:00
Code Issues Packages Projects Releases Wiki Activity

- fixed vulnerability with banned keys (made them not case-sensitive);

Browse Source
This commit is contained in:
Mykyta Synelnikov
2023-06-28 11:17:28 +03:00
parent 310c00d978
commit fc07de48b7
4 changed files with 50 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/core/class-form.php
+18 -2
View File
@@ -390,6 +390,22 @@ if ( ! class_exists( 'um\core\Form' ) ) {
}
}
/**
* Remove banned wp_usermeta keys from submitted data.
*
* @since 2.6.5
* @param array $submitted
* @return array
*/
public function clean_submitted_data( $submitted ) {
foreach ( $submitted as $metakey => $value ) {
if ( UM()->user()->is_metakey_banned( $metakey ) ) {
unset( $submitted[ $metakey ] );
}
}
return $submitted;
}
/**
* Validate form on submit
@@ -478,10 +494,10 @@ if ( ! class_exists( 'um\core\Form' ) ) {
// Secure sanitize of the submitted data
if ( ! empty( $this->post_form ) ) {
$this->post_form = array_diff_key( $this->post_form, array_flip( UM()->user()->banned_keys ) );
$this->post_form = $this->clean_submitted_data( $this->post_form );
}
if ( ! empty( $this->post_form['submitted'] ) ) {
$this->post_form['submitted'] = array_diff_key( $this->post_form['submitted'], array_flip( UM()->user()->banned_keys ) );
$this->post_form['submitted'] = $this->clean_submitted_data( $this->post_form['submitted'] );
}
// set default role from settings on registration form