10h30/display-featured-image-genesis
1
0
Fork 0
mirror of https://github.com/10h30/display-featured-image-genesis.git synced 2026-07-19 22:43:24 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix image accessibility on settings page

Browse Source
This commit is contained in:
Robin Cornett
2016-04-18 11:53:13 -04:00
parent ae28629210
commit 967af40305
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/class-displayfeaturedimagegenesis-helper.php
+7 -5
View File
@@ -153,18 +153,20 @@ class Display_Featured_Image_Genesis_Helper {
/**
* display image preview
* @param int $id featured image ID
* @param $alt string description for alt text
* @return $image image preview
*
* @since 2.3.0
*/
public function render_image_preview( $id ) {
public function render_image_preview( $id, $alt ) {
if ( empty( $id ) ) {
return;
}
$id = displayfeaturedimagegenesis_check_image_id( $id );
$preview = wp_get_attachment_image_src( (int) $id, 'medium' );
$image = sprintf( '<div class="upload_logo_preview"><img src="%s" /></div>', esc_url( $preview[0] ) );
$id = displayfeaturedimagegenesis_check_image_id( $id );
$alt_text = sprintf( __( '%s featured image', 'display-featured-image-genesis' ), $alt );
$preview = wp_get_attachment_image_src( (int) $id, 'medium' );
$image = sprintf( '<div class="upload_logo_preview"><img src="%s" alt="%s" /></div>', esc_url( $preview[0] ), esc_attr( $alt_text ) );
return $image;
}
@@ -179,7 +181,7 @@ class Display_Featured_Image_Genesis_Helper {
public function render_buttons( $id, $name ) {
$id = displayfeaturedimagegenesis_check_image_id( $id );
$id = $id ? (int) $id : '';
printf( '<input type="hidden" class="upload_image_id" id="%1$s" name="%1$s" value="%2$s" />', esc_attr( $name ), esc_attr( $id ) );
printf( '<input type="hidden" class="upload_image_id" name="%1$s" value="%2$s" />', esc_attr( $name ), esc_attr( $id ) );
printf( '<input id="%s" type="button" class="upload_default_image button-secondary" value="%s" />',
esc_attr( $name ),
esc_attr__( 'Select Image', 'display-featured-image-genesis' )
includes/class-displayfeaturedimagegenesis-settings.php
+2 -2
View File
@@ -312,7 +312,7 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
$id = $this->setting['default'] ? $this->setting['default'] : '';
$name = 'displayfeaturedimagegenesis[default]';
if ( ! empty( $id ) ) {
echo wp_kses_post( $this->render_image_preview( $id ) );
echo wp_kses_post( $this->render_image_preview( $id, 'default' ) );
}
$this->render_buttons( $id, $name );
$this->do_description( 'default_image' );
@@ -361,7 +361,7 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
$id = $this->setting['post_type'][ $post_type ];
$name = 'displayfeaturedimagegenesis[post_type][' . esc_attr( $post_type ) . ']';
if ( $id ) {
echo wp_kses_post( $this->render_image_preview( $id ) );
echo wp_kses_post( $this->render_image_preview( $id, $post_type ) );
}
$this->render_buttons( $id, $name );