10h30/display-featured-image-genesis
1
0
Fork 0
mirror of https://github.com/10h30/display-featured-image-genesis.git synced 2026-07-11 18:46:03 +09:00
Code Issues Packages Projects Releases Wiki Activity

Tidy settings/validation

Browse Source
This commit is contained in:
Robin Cornett
2016-04-04 10:31:57 -04:00
parent 7fb24b1086
commit 9d19d5ddcb
2 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/class-displayfeaturedimagegenesis-helper.php
+17 -2
View File
@@ -172,8 +172,8 @@ class Display_Featured_Image_Genesis_Helper {
/**
* show image select/delete buttons
* @param variable $id image ID
* @param varable $name name for value/ID/class
* @param int $id image ID
* @param string $name name for value/ID/class
* @return $buttons select/delete image buttons
*
* @since 2.3.0
@@ -193,6 +193,21 @@ class Display_Featured_Image_Genesis_Helper {
}
}
/**
* Get all public content types.
* @return array
*/
protected function get_content_types() {
$args = array(
'public' => true,
'_builtin' => false,
'has_archive' => true,
);
$output = 'names';
return get_post_types( $args, $output );
}
/**
* Determines if the user has permission to save the information from the submenu
* page.
includes/class-displayfeaturedimagegenesis-settings.php
+6 -23
View File
@@ -155,21 +155,6 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
);
}
/**
* Get all public content types.
* @return array
*/
protected function get_content_types() {
$args = array(
'public' => true,
'_builtin' => false,
'has_archive' => true,
);
$output = 'names';
return get_post_types( $args, $output );
}
/**
* Register plugin settings fields
* @param array $sections registerd sections
@@ -421,7 +406,8 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
$new_value['default'] = $this->validate_image( $new_value['default'], $this->setting['default'], __( 'Default', 'display-featured-image-genesis' ), $size_to_check );
// search/404
$custom_pages = array(
$size_to_check = get_option( 'medium_size_w' );
$custom_pages = array(
array(
'id' => 'search',
'label' => __( 'Search Results', 'display-featured-image-genesis' ),
@@ -438,17 +424,14 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
foreach ( $this->post_types as $post_type ) {
$object = get_post_type_object( $post_type );
// extra variables to pass through to image validation
$old_value = isset( $this->setting['post_type'][ $object->name ] ) ? $this->setting['post_type'][ $object->name ] : '';
$label = $object->label;
$size_to_check = get_option( 'medium_size_w' );
$object = get_post_type_object( $post_type );
$old_value = isset( $this->setting['post_type'][ $object->name ] ) ? $this->setting['post_type'][ $object->name ] : '';
$label = $object->label;
// sanitize
$new_value['post_type'][ $post_type ] = $this->validate_image( $new_value['post_type'][ $post_type ], $old_value, $label, $size_to_check );
$new_value['fallback'][ $post_type ] = $this->one_zero( $new_value['fallback'][ $post_type ] );
}
$built_ins = array( 'post', 'page' );
$built_ins = array( 'post', 'page' );
$post_types = array_merge( $built_ins, $this->post_types );
foreach ( $post_types as $post_type ) {
$new_value['skip'][ $post_type ] = $this->one_zero( $new_value['skip'][ $post_type ] );