10h30/display-featured-image-genesis
1
0
Fork 0
mirror of https://github.com/10h30/display-featured-image-genesis.git synced 2026-07-20 06:53:23 +09:00
Code Issues Packages Projects Releases Wiki Activity

escaping many things (#WWGJD)

Browse Source
This commit is contained in:
Robin Cornett
2015-04-19 16:27:57 -04:00
parent bd10c340fb
commit df891465b3
2 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/class-displayfeaturedimagegenesis-admin.php
+4 -4
View File
@@ -3,11 +3,11 @@
/**
* Dependent class to establish/display columns for featured images
*
* @package DisplayFeaturedImageGenesis
* @package DisplayFeaturedImageGenesis
* @author Robin Cornett <hello@robincornett.com>
* @license GPL-2.0+
* @link http://robincornett.com
* @copyright 2014 Robin Cornett Creative, LLC
* @copyright 2015 Robin Cornett Creative, LLC
* @since 2.0.0
*/
@@ -97,7 +97,7 @@ class Display_Featured_Image_Genesis_Admin {
$id = Display_Featured_Image_Genesis_Common::get_image_id( $term_meta['term_image'] );
}
$preview = apply_filters( 'display_featured_image_genesis_admin_term_thumbnail', wp_get_attachment_image_src( $id, 'thumbnail' ), $id );
echo '<img src="' . $preview[0] . '" alt="' . $alt_tag . '" />';
echo '<img src="' . esc_url( $preview[0] ) . '" alt="' . esc_attr( $alt_tag ) . '" />';
}
}
@@ -117,7 +117,7 @@ class Display_Featured_Image_Genesis_Admin {
$id = get_post_thumbnail_id( $post_id );
$preview = apply_filters( 'display_featured_image_genesis_admin_post_thumbnail', wp_get_attachment_image_src( $id, 'thumbnail' ), $id );
if ( $id ) {
echo '<img src="' . $preview[0] . '" alt="' . the_title_attribute( 'echo=0' ) . '" />';
echo '<img src="' . esc_url( $preview[0] ) . '" alt="' . esc_attr( the_title_attribute( 'echo=0' ) ) . '" />';
}
}
includes/helper-functions.php
+16 -12
View File
@@ -33,7 +33,7 @@ function display_featured_image_genesis_get_term_image_id() {
}
}
return $image_id;
return absint( $image_id );
}
@@ -44,12 +44,12 @@ function display_featured_image_genesis_get_term_image_id() {
*
* @since 2.1.0
*/
function display_featured_image_genesis_get_term_image_url( $size='displayfeaturedimage_backstretch' ) {
function display_featured_image_genesis_get_term_image_url( $size = 'displayfeaturedimage_backstretch' ) {
$image_id = display_featured_image_genesis_get_term_image_id();
$image_url = wp_get_attachment_image_src( $image_id, $size );
return $image_url[0];
return esc_url( $image_url[0] );
}
@@ -61,11 +61,15 @@ function display_featured_image_genesis_get_term_image_url( $size='displayfeatur
*/
function display_featured_image_genesis_get_default_image_id() {
$image_id = '';
$item = Display_Featured_Image_Genesis_Common::get_image_variables();
$image_id = $item->fallback_id;
$image_id = '';
$displaysetting = get_option( 'displayfeaturedimagegenesis' );
$fallback = $displaysetting['default'];
$image_id = $fallback;
if ( ! is_numeric( $fallback ) ) {
$image_id = self::get_image_id( $fallback ); // gets image id with attached metadata
}
return $image_id;
return absint( $image_id );
}
@@ -76,12 +80,12 @@ function display_featured_image_genesis_get_default_image_id() {
*
* @since 2.1.0
*/
function display_featured_image_genesis_get_default_image_url( $size='displayfeaturedimage_backstretch' ) {
function display_featured_image_genesis_get_default_image_url( $size = 'displayfeaturedimage_backstretch' ) {
$image_id = display_featured_image_genesis_get_default_image_id();
$image_url = wp_get_attachment_image_src( $image_id, $size );
return $image_url[0];
return esc_url( $image_url[0] );
}
@@ -116,7 +120,7 @@ function display_featured_image_genesis_get_cpt_image_id() {
}
}
return $image_id;
return absint( $image_id );
}
/**
@@ -126,12 +130,12 @@ function display_featured_image_genesis_get_cpt_image_id() {
*
* @since 2.1.0
*/
function display_featured_image_genesis_get_cpt_image_url( $size='displayfeaturedimage_backstretch' ) {
function display_featured_image_genesis_get_cpt_image_url( $size = 'displayfeaturedimage_backstretch' ) {
$image_id = display_featured_image_genesis_get_cpt_image_id();
$image_url = wp_get_attachment_image_src( $image_id, $size );
return $image_url[0];
return esc_url( $image_url[0] );
}