10h30/display-featured-image-genesis
1
0
Fork 0
mirror of https://github.com/10h30/display-featured-image-genesis.git synced 2026-07-20 06:53:23 +09:00
Code Issues Packages Projects Releases Wiki Activity

Instantiate description class only as needed

Browse Source
This commit is contained in:
Robin Cornett
2019-05-13 14:40:02 -04:00
parent 97e7df22f7
commit f544a90974
2 changed files with 27 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/class-displayfeaturedimagegenesis-output.php
+26 -12
View File
@@ -216,15 +216,12 @@ class Display_Featured_Image_Genesis_Output {
* @since 1.0.0
*/
public function do_backstretch_image_title() {
$this->description = new Display_Featured_Image_Genesis_Description();
$scriptless = displayfeaturedimagegenesis_get_setting( 'scriptless' );
if ( $this->move_title() ) {
$this->remove_title_descriptions();
}
$class = 'big-leader';
$class = 'big-leader';
$scriptless = displayfeaturedimagegenesis_get_setting( 'scriptless' );
if ( $scriptless ) {
$class .= ' big-leader--scriptless';
}
@@ -339,7 +336,8 @@ class Display_Featured_Image_Genesis_Output {
* @since 2.3.1
*/
protected function do_the_title() {
if ( is_front_page() && ! $this->description->show_front_page_title() ) {
$description = $this->get_description_class();
if ( is_front_page() && ! $description->show_front_page_title() ) {
return '';
}
$class = is_singular() ? 'entry-title' : 'archive-title';
@@ -359,10 +357,10 @@ class Display_Featured_Image_Genesis_Output {
*
*/
public function add_descriptions() {
$this->description->do_tax_description();
$this->description->do_author_description();
$this->description->do_cpt_archive_description();
$description = $this->get_description_class();
$description->do_tax_description();
$description->do_author_description();
$description->do_cpt_archive_description();
}
@@ -372,8 +370,9 @@ class Display_Featured_Image_Genesis_Output {
* @since 2.3.1
*/
protected function do_title_descriptions() {
$this->description->do_front_blog_excerpt();
$this->description->do_excerpt();
$description = $this->get_description_class();
$description->do_front_blog_excerpt();
$description->do_excerpt();
genesis_do_taxonomy_title_description();
genesis_do_author_title_description();
genesis_do_cpt_archive_title_description();
@@ -541,6 +540,21 @@ class Display_Featured_Image_Genesis_Output {
return $this->common;
}
/**
* Instantiate the description class as needed.
* @return \Display_Featured_Image_Genesis_Description
* @since 3.1.0
*/
protected function get_description_class() {
if ( isset( $this->description ) ) {
return $this->description;
}
include_once 'class-displayfeaturedimagegenesis-description.php';
$this->description = new Display_Featured_Image_Genesis_Description();
return $this->description;
}
/**
* Get the current featured image and related variables.
* @return \stdClass
includes/class-displayfeaturedimagegenesis.php
+1 -3
View File
@@ -89,18 +89,16 @@ class Display_Featured_Image_Genesis {
* @param $author
* @param $common
* @param $customizer
* @param $description
* @param $output
* @param $rss
* @param $settings
* @param $taxonomies
*/
public function __construct( $admin, $author, $common, $customizer, $description, $output, $post_meta, $rss, $settings, $taxonomies, $widgets ) {
public function __construct( $admin, $author, $common, $customizer, $output, $post_meta, $rss, $settings, $taxonomies, $widgets ) {
$this->admin = $admin;
$this->author = $author;
$this->common = $common;
$this->customizer = $customizer;
$this->description = $description;
$this->output = $output;
$this->post_meta = $post_meta;
$this->rss = $rss;