10h30/wp-strava
1
0
Fork 0
mirror of https://github.com/10h30/wp-strava.git synced 2026-07-11 18:56:18 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix pace styles and water pace speeds

Browse Source
This commit is contained in:
Justin Foell
2020-12-24 11:53:14 -06:00
parent cc835e089c
commit afc132becd
3 changed files with 21 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
readme.txt
+3
View File
@@ -116,6 +116,9 @@ On the WP-Strava settings page you cannot currently remove and add another athle
= Unreleased =
Fix latest_map class replacing echo with return https://wordpress.org/support/topic/latest-activity-map-shortcode-wrong-placed-on-page/
Fix styling on pace activity max speed.
Fix broken water pace on activity.
Fix pace types and remove 'other' - making 'speed' default.
= 2.5.0 =
src/WPStrava/ActivityRenderer.php
+12 -14
View File
@@ -98,20 +98,11 @@ class WPStrava_ActivityRenderer {
<div class="activity-details-table-units">' . $strava_som->get_pace_label() . '</div>
</td>';
$max_speed = '<td data-label="' . __( 'Max Speed', 'wp-strava' ) . '">
<div>' . $strava_som->pace( $activity_details->max_speed ) . '</div>
<div class="activity-details-table-info">' . $strava_som->pace( $activity_details->max_speed ) . '</div>
<div class="activity-details-table-units">' . $strava_som->get_pace_label() . '</div>
</td>';
break;
case WPStrava_ActivityType::TYPE_GROUP_SPEED:
$avg_speed = '<td data-label="' . __( 'Average Speed', 'wp-strava' ) . '">
<div class="activity-details-table-info">' . $strava_som->speed( $activity_details->average_speed ) . '</div>
<div class="activity-details-table-units">' . $strava_som->get_speed_label() . '</div>
</td>';
$max_speed = '<td data-label="' . __( 'Max Speed', 'wp-strava' ) . '">
<div class="activity-details-table-info">' . $strava_som->speed( $activity_details->max_speed ) . '</div>
<div class="activity-details-table-units">' . $strava_som->get_speed_label() . '</div>
</td>';
break;
case WPStrava_ActivityType::TYPE_GROUP_PACE:
case WPStrava_ActivityType::TYPE_GROUP_WATER:
$avg_speed = '<td data-label="' . __( 'Average Speed', 'wp-strava' ) . '">
<div class="activity-details-table-info">' . $strava_som->swimpace( $activity_details->average_speed ) . '</div>
<div class="activity-details-table-units">' . $strava_som->get_swimpace_label() . '</div>
@@ -121,9 +112,16 @@ class WPStrava_ActivityRenderer {
<div class="activity-details-table-units">' . $strava_som->get_swimpace_label() . '</div>
</td>';
break;
case WPStrava_ActivityType::TYPE_GROUP_SPEED:
default:
$avg_title = '';
$max_title = '';
$avg_speed = '<td data-label="' . __( 'Average Speed', 'wp-strava' ) . '">
<div class="activity-details-table-info">' . $strava_som->speed( $activity_details->average_speed ) . '</div>
<div class="activity-details-table-units">' . $strava_som->get_speed_label() . '</div>
</td>';
$max_speed = '<td data-label="' . __( 'Max Speed', 'wp-strava' ) . '">
<div class="activity-details-table-info">' . $strava_som->speed( $activity_details->max_speed ) . '</div>
<div class="activity-details-table-units">' . $strava_som->get_speed_label() . '</div>
</td>';
break;
}
src/WPStrava/ActivityType.php
+6 -14
View File
@@ -1,6 +1,6 @@
<?php
/**
* ActivityType [activitytype].
* ActivityType [activitytype].
* @package WPStrava
*/
@@ -45,22 +45,18 @@ class WPStrava_ActivityType {
const TYPE_WORKOUT = 'Workout';
const TYPE_YOGA = 'Yoga';
const TYPE_DEFAULT = self::TYPE_RIDE;
private static $water_types = array( self::TYPE_SWIM );
private static $pace_types = array( self::TYPE_CANOEING, self::TYPE_HIKE, self::TYPE_RUN, self::TYPE_SNOWSHOE, self::TYPE_VIRTUALRUN, self::TYPE_WALK );
private static $speed_types = array( self::TYPE_ALPINESKI, self::TYPE_BACKCOUNTRYSKI, self::TYPE_EBIKERIDE, self::TYPE_ELLIPTICAL, self::TYPE_HANDCYCLE, self::TYPE_ICESKATE, self::TYPE_INLINESKATE, self::TYPE_KAYAKING, self::TYPE_KITESURF, self::TYPE_NORDICSKI, self::TYPE_RIDE, self::TYPE_ROCKCLIMBING, self::TYPE_ROLLERSKI, self::TYPE_ROWING, self::TYPE_SNOWBOARD, self::TYPE_STAIRSTEPPER, self::TYPE_STANDUPPADDLING, self::TYPE_SURFING, self::TYPE_VIRTUALRIDE, self::TYPE_WHEELCHAIR, self::TYPE_WINDSURF );
private static $water_types = array( self::TYPE_SWIM );
const TYPE_GROUP_WATER = 'water';
const TYPE_GROUP_PACE = 'pace';
const TYPE_GROUP_WATER = 'water';
const TYPE_GROUP_SPEED = 'speed';
const TYPE_GROUP_OTHER = 'other';
/**
* Get the type of activity.
* Get the type of activity - defaults to 'speed'.
*
* @param string $type Type provided by Strava.
* @return string Type group (water/pace/speed/other).
* @return string Type group (pace/water/speed).
* @author Sebastian Erb <mail@sebastianerb.com>
* @since 1.7.0
*/
@@ -70,15 +66,11 @@ class WPStrava_ActivityType {
return self::TYPE_GROUP_PACE;
}
if ( in_array( $type, self::$speed_types, true ) ) {
return self::TYPE_GROUP_SPEED;
}
if ( in_array( $type, self::$water_types, true ) ) {
return self::TYPE_GROUP_WATER;
}
return self::TYPE_GROUP_OTHER;
return self::TYPE_GROUP_SPEED;
}
}