Fix label for number input accessibility

This commit is contained in:
Robin Cornett
2016-04-18 11:53:43 -04:00
parent 967af40305
commit 1dd17de8e9
2 changed files with 4 additions and 5 deletions
@@ -69,14 +69,13 @@ class Display_Featured_Image_Genesis_Helper {
* @since 2.3.0
*/
public function do_number( $args ) {
printf( '<label for="%s[%s]">%s</label>', esc_attr( $this->page ),esc_attr( $args['setting'] ), esc_attr( $args['label'] ) );
printf( '<input type="number" step="1" min="%1$s" max="%2$s" id="%5$s[%3$s]" name="%5$s[%3$s]" value="%4$s" class="small-text" />',
printf( '<label for="%5$s[%3$s]"><input type="number" step="1" min="%1$s" max="%2$s" id="%5$s[%3$s]" name="%5$s[%3$s]" value="%4$s" class="small-text" />%6$s</label>',
(int) $args['min'],
(int) $args['max'],
esc_attr( $args['setting'] ),
esc_attr( $this->setting[ $args['setting'] ] ),
esc_attr( $this->page )
esc_attr( $this->page ),
esc_attr( $args['label'] )
);
$this->do_description( $args['setting'] );
@@ -176,7 +176,7 @@ class Display_Featured_Image_Genesis_Settings extends Display_Featured_Image_Gen
'title' => __( 'Height' , 'display-featured-image-genesis' ),
'callback' => 'do_number',
'section' => 'main',
'args' => array( 'setting' => 'less_header', 'label' => __( 'Pixels to remove ', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 400 ),
'args' => array( 'setting' => 'less_header', 'label' => __( 'pixels to remove', 'display-featured-image-genesis' ), 'min' => 0, 'max' => 400 ),
),
array(
'id' => 'default',